feat(codex): add native hooks integration by sf-jin-ku · Pull Request #899 · rtk-ai/rtk

sf-jin-ku · 2026-03-28T14:44:36Z

Summary

add native Codex PreToolUse integration via rtk hook codex
extend rtk init --codex to patch .codex/config.toml and .codex/hooks.json
fall back to prompt-only Codex setup on Windows and honor CODEX_HOME for global installs

Problem

rtk init --codex was prompt-only. It wrote RTK.md and patched AGENTS.md, but it did not install Codex lifecycle hooks, so Codex had no hard guardrail to route supported raw Bash commands through rtk.

What changed

Hook runtime

add rtk hook codex
reuse the existing rewrite source of truth via get_rewritten()
for supported raw Bash commands, return Codex-native permissionDecision: "deny" with the exact rtk ... replacement
pass through unchanged for unsupported commands, excluded commands, heredocs, and already-rtk commands

Codex install / uninstall / show

rtk init --codex now patches:
- RTK.md
- AGENTS.md
- .codex/config.toml
- .codex/hooks.json
ensure features.codex_hooks = true
install one PreToolUse matcher group for Bash
rtk init --show --codex now reports local/global Codex hook state
rtk init --codex --uninstall now supports local uninstall
leave codex_hooks = true in place on uninstall, but remove RTK-managed hook entries

Compatibility / edge cases

use CODEX_HOME for global Codex path resolution instead of hardcoding ~/.codex
on Windows, fall back to the old prompt-only Codex setup because upstream Codex disables lifecycle hooks there
local .codex installs still depend on Codex project trust
update Codex-facing docs and hook README/test layout to match the current hook structure under src/hooks and hooks/codex

Test plan

cargo test --all
cargo build && RTK=target/debug/rtk bash hooks/codex/test-rtk-rewrite.sh

Notes

Codex currently does not support transparent updatedInput rewrites for PreToolUse, so this integration uses deny-and-retry instead of the Claude/Cursor transparent rewrite flow.

Signed-off-by: Jin Ku <jin.ku@sendbird.com>

…y-hooks

CLAassistant · 2026-03-30T18:40:39Z

All committers have signed the CLA.

…by-hooks # Conflicts: # src/hooks/init.rs # src/main.rs

pragmaton · 2026-03-31T10:03:32Z

This is a solid improvement!

One important gap still seems unresolved: rtk verify still checks only the Claude hook path (~/.claude/hooks/rtk-rewrite.sh) and does not verify Codex hook installation/state.

That means after this PR, a Codex user can run rtk init -g --codex, get .codex/config.toml + .codex/hooks.json configured correctly, and still see:

SKIP RTK hook not installed

Signed-off-by: Jin Ku <jin.ku@sendbird.com>

sf-jin-ku · 2026-03-31T18:15:00Z

This is a solid improvement!

One important gap still seems unresolved: rtk verify still checks only the Claude hook path (~/.claude/hooks/rtk-rewrite.sh) and does not verify Codex hook installation/state.

That means after this PR, a Codex user can run rtk init -g --codex, get .codex/config.toml + .codex/hooks.json configured correctly, and still see:

SKIP RTK hook not installed

Thanks! It has been fixed!

rolandkakonyi · 2026-04-01T07:14:13Z

@sf-jin-ku did you verify that Codex actually resolves the @RTK.md from a user-global ~/.codex/AGENTS.md?

I tried this branch and it seems this is a Codex limitation that @FILE is not resolved in global AGENTS.md but only in project-local AGENTS.md files.

See issue on Codex here: openai/codex#6038

A workaround could be to just inline the contents of RTK.md (wrapped into some markers maybe) to unblock global rtk installs.

Signed-off-by: Jin Ku <jin.ku@sendbird.com>

sf-jin-ku · 2026-04-03T10:06:55Z

@rolandkakonyi addressed in e633de6.

I changed the Codex install path so it no longer relies on @RTK.md resolution for either global or project-local Codex installs. rtk init --codex now writes RTK-managed guidance inline into AGENTS.md, migrates legacy @RTK.md installs forward, and rtk verify now reports Codex AGENTS.md health explicitly alongside the Codex hook/config status.

That means global $CODEX_HOME/AGENTS.md / ~/.codex/AGENTS.md no longer depends on upstream @file include support.

Signed-off-by: Jin Ku <jin.ku@sendbird.com>

sf-jin-ku · 2026-04-03T22:39:35Z

@aeppling quick note on the pending CLAassistant check: the only unsigned committer appears to be github-actions[bot], coming from commit 51939a5 (chore(master): release 0.34.2) that entered this branch when I merged upstream history earlier in the review cycle. The human contributors on this PR have already signed.

Also, 0.34.2 is no longer the current release line anyway: the latest stable release is v0.34.3 (April 2, 2026), and the repo is already publishing dev-0.35.0-rc.* prereleases today (latest I see is dev-0.35.0-rc.108 from April 3, 2026).

If the implementation looks good otherwise, could you bypass/ignore the CLAassistant pending state for this PR and include it in a later release batch instead of tying it to 0.34.2? The branch is mergeable again and includes the follow-up fixes for global Codex AGENTS guidance plus the rtk verify updates.

Signed-off-by: Jin Ku <jin.ku@sendbird.com>

callme-sy · 2026-04-17T03:27:21Z

this looks good.

one thing i was wondering about is the rewrite-miss path.

from the PR it looks like commands that rtk rewrite can map get the deny-and-retry flow with the exact rtk ... replacement, and everything else passes through unchanged.

i’ve been testing a local codex hook prototype around the same idea, and i ran into a couple cases where rtk rewrite missed but direct rtk <cmd> still worked better.

do you think there’s eventually room for a lighter fallback for some rewrite misses before leaving the original command unchanged?

sf-jin-ku marked this pull request as ready for review March 28, 2026 14:47

sf-jin-ku changed the title ~~[codex] add native hooks integration for Codex CLI~~ feat(codex): add native hooks integration with Windows fallback Mar 28, 2026

sf-jin-ku changed the title ~~feat(codex): add native hooks integration with Windows fallback~~ feat(codex): add native hooks integration Mar 28, 2026

feat(codex): add native hooks integration

93537d3

Signed-off-by: Jin Ku <jin.ku@sendbird.com>

sf-jin-ku force-pushed the codex-integration-by-hooks branch from 06e614b to 93537d3 Compare March 28, 2026 14:56

Merge remote-tracking branch 'origin/master' into codex-integration-b…

f9e358b

…y-hooks

Merge remote-tracking branch 'origin/develop' into codex-integration-…

27cba05

…by-hooks # Conflicts: # src/hooks/init.rs # src/main.rs

sf-jin-ku added 2 commits March 31, 2026 04:05

fix(codex): show codex hook status in verify

f65b0fd

Signed-off-by: Jin Ku <jin.ku@sendbird.com>

fix(cli): preserve command exit codes

ce23edb

Signed-off-by: Jin Ku <jin.ku@sendbird.com>

fix(codex): inline and verify AGENTS guidance

e633de6

Signed-off-by: Jin Ku <jin.ku@sendbird.com>

Merge origin/develop into codex-integration-by-hooks

ace64f4

Signed-off-by: Jin Ku <jin.ku@sendbird.com>

Merge origin/develop into codex-integration-by-hooks

e2af770

Signed-off-by: Jin Ku <jin.ku@sendbird.com>

aeppling self-assigned this Apr 6, 2026

sf-jin-ku added 8 commits April 7, 2026 23:18

test(codex): fix uninstall warning on windows

33bad57

Signed-off-by: Jin Ku <jin.ku@sendbird.com>

Merge origin/develop into codex-integration-by-hooks

656171d

Signed-off-by: Jin Ku <jin.ku@sendbird.com>

Merge origin/develop into codex-integration-by-hooks

f03e80a

Signed-off-by: Jin Ku <jin.ku@sendbird.com>

feat(codex): enable Windows hooks on 0.120.0+

c952633

Merge origin/develop into codex-integration-by-hooks

1ca5c05

test(ci): cover codex windows version gating

1d2b98d

fix(ci): compute windows smoke paths at runtime

21519dc

Merge origin/develop into codex-integration-by-hooks

0c33a7b

aeppling mentioned this pull request Apr 22, 2026

Fix Codex global RTK reference path on macOS #1002

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(codex): add native hooks integration#899

feat(codex): add native hooks integration#899
sf-jin-ku wants to merge 16 commits intortk-ai:developfrom
sf-jin-ku:codex-integration-by-hooks

sf-jin-ku commented Mar 28, 2026

Uh oh!

CLAassistant commented Mar 30, 2026 •

edited

Loading

Uh oh!

pragmaton commented Mar 31, 2026

Uh oh!

sf-jin-ku commented Mar 31, 2026

Uh oh!

rolandkakonyi commented Apr 1, 2026

Uh oh!

sf-jin-ku commented Apr 3, 2026

Uh oh!

sf-jin-ku commented Apr 3, 2026

Uh oh!

callme-sy commented Apr 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

sf-jin-ku commented Mar 28, 2026

Summary

Problem

What changed

Hook runtime

Codex install / uninstall / show

Compatibility / edge cases

Test plan

Notes

Uh oh!

CLAassistant commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pragmaton commented Mar 31, 2026

Uh oh!

sf-jin-ku commented Mar 31, 2026

Uh oh!

rolandkakonyi commented Apr 1, 2026

Uh oh!

sf-jin-ku commented Apr 3, 2026

Uh oh!

sf-jin-ku commented Apr 3, 2026

Uh oh!

callme-sy commented Apr 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

CLAassistant commented Mar 30, 2026 •

edited

Loading